feat: Support snapstart's vended credentials #532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanista
reviewed
Jan 29, 2025
duncanista
reviewed
Jan 30, 2025
Comment on lines
+131
to
+146
| PlatformRestoreStart { | ||
| // function name and function version are here | ||
| // but we don't care about those | ||
| // https://docs.aws.amazon.com/lambda/latest/dg/telemetry-schema-reference.html#platform-restoreStart | ||
| // runtime version may be nice | ||
| }, | ||
|
|
||
| #[serde(rename = "platform.restoreReport", rename_all = "camelCase")] | ||
| PlatformRestoreReport { | ||
| /// Status of the invocation | ||
| status: Status, | ||
| /// When unsuccessful, the `error_type` describes what kind of error occurred | ||
| error_type: Option<String>, | ||
| }, | ||
| #[serde(rename = "platform.restoreRuntimeDone", rename_all = "camelCase")] | ||
| PlatformRestoreRuntimeDone { |
Contributor
There was a problem hiding this comment.
Maybe we could provide some snapstart visibility eventually? seems easy enough
Contributor
Author
There was a problem hiding this comment.
I think we could report the metric, yeah
Contributor
Author
There was a problem hiding this comment.
Why? It happens up to 2 weeks before an invocation occurs
duncanista
approved these changes
Jan 30, 2025
Contributor
|
Looks good! Fix clippy and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lambda SnapStart doesn't provide AWS access credentials to prevent them from being cached during the snapshot creation process.
We have two options, we can delay resolving credentials into the invoke phase (probably don't wanna do that for performance reasons where users rely on the additional vCPU power during init), or we can use the credential API to grab creds during init and use them.
Since we never re-use credentials, this works fine for us. It should only incur overhead during snapshot creation, which is a control plane operation anyway.
Screenshot of the decrypted secrets w/ snapshot (long since expired):
(can't wait for a bot to try these old expired creds)